linux-kernel - Re: [PATCH] pinctrl: intel: Assume 0 by default for PNP UID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya84odaFgmqygJ2I@smile.fi.intel.com>
Date:   Tue, 7 Dec 2021 12:34:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "andy@...nel.org" <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: intel: Assume 0 by default for PNP UID

On Tue, Dec 07, 2021 at 11:48:23AM +0800, Kai-Heng Feng wrote:
> On Sat, Dec 4, 2021 at 8:49 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Saturday, December 4, 2021, Kai-Heng Feng
> > <kai.heng.feng@...onical.com> wrote:
> > >
> > > There's an EHL board that the DSDT doesn't have _UID for pinctrl device,
> > > and that causes a NULL pointer dereference in strcmp().
> > >
> > > So in the absence of _UID, assume it's 0 by default to avoid the issue
> > > and get a pinmap.
> >
> > Do you have updated firmware?
> 
> Customer confirmed new code drop from Intel does have _UID defined.
> So I guess this patch is not needed anymore?

It is not, this is the idea, thanks for confirming!

-- 
With Best Regards,
Andy Shevchenko