linux-kernel - Re: [pdx86-platform-drivers-x86:review-hans 41/44] drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous prototype for 'yogabook_wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Dec 2021 12:22:06 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        kernel test robot <lkp@...el.com>
Cc:     Yauhen Kharuzhy <jekhor@...il.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [pdx86-platform-drivers-x86:review-hans 41/44]
 drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous
 prototype for 'yogabook_wmi_suspend'

Hi,

On 12/7/21 11:38, Andy Shevchenko wrote:
> On Tue, Dec 07, 2021 at 09:42:46AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
>> head:   cb01df9ef827442739051c6457962a5c6bc85d99
>> commit: 4709e8b835ec25e8627844e9927804f814b64fd4 [41/44] platform/x86: lenovo-yogabook-wmi: Add driver for Lenovo Yoga Book
>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211207/202112070945.X05c2wgI-lkp@intel.com/config)
>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>> reproduce (this is a W=1 build):
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=4709e8b835ec25e8627844e9927804f814b64fd4
>>         git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>>         git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>>         git checkout 4709e8b835ec25e8627844e9927804f814b64fd4
>>         # save the config file to linux build tree
>>         mkdir build_dir
>>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous prototype for 'yogabook_wmi_suspend' [-Wmissing-prototypes]
>>      278 | __maybe_unused int yogabook_wmi_suspend(struct device *dev)
>>          |                    ^~~~~~~~~~~~~~~~~~~~
>>>> drivers/platform/x86/lenovo-yogabook-wmi.c:294:20: warning: no previous prototype for 'yogabook_wmi_resume' [-Wmissing-prototypes]
>>      294 | __maybe_unused int yogabook_wmi_resume(struct device *dev)
>>          |                    ^~~~~~~~~~~~~~~~~~~
> 
> Despite missed static, we usually put __maybe_unused between type and function
> name in this cases.

Right. I've just done a forced-push to review-hans fixing both issues.

Regards,

Hans