linux-kernel - [PATCH] thermal/drivers/int340x: fix: update VCoRefLow MMIO bit offset for read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  7 Dec 2021 18:05:39 +0530
From:   Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>
To:     srinivas.pandruvada@...ux.intel.com, rafael@...nel.org,
        daniel.lezcano@...aro.org, rui.zhang@...el.com, amitk@...nel.org,
        linux-pm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        sumeet.r.pawnikar@...el.com
Subject: [PATCH] thermal/drivers/int340x: fix: update VCoRefLow MMIO bit offset for read

As part of RFIM validation, found that the register definition VCoRefLow
of the CPU FIVR registers are different. Current implementation reads it
from MMIO offset 0x5A18 and bit offset [12:14]. But the actual correct
register definition is from bit offset [11:13]. Updated to the correct
bit offset.

Fixes: 473be51142ad ("thermal: int340x: processor_thermal: Add RFIM driver")
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>
Cc: stable@...r.kernel.org # 5.14+
---
 drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
index b25b54d4bac1..e693ec8234fb 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
@@ -29,7 +29,7 @@ static const char * const fivr_strings[] = {
 };
 
 static const struct mmio_reg tgl_fivr_mmio_regs[] = {
-	{ 0, 0x5A18, 3, 0x7, 12}, /* vco_ref_code_lo */
+	{ 0, 0x5A18, 3, 0x7, 11}, /* vco_ref_code_lo */
 	{ 0, 0x5A18, 8, 0xFF, 16}, /* vco_ref_code_hi */
 	{ 0, 0x5A08, 8, 0xFF, 0}, /* spread_spectrum_pct */
 	{ 0, 0x5A08, 1, 0x1, 8}, /* spread_spectrum_clk_enable */
-- 
2.17.1