linux-kernel - Re: [PATCH] staging: r8188eu: convert type of HalData in struct adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8365eb19-2a03-d053-cfad-22bd54fc1554@gmail.com>
Date:   Tue, 7 Dec 2021 13:47:59 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: convert type of HalData in struct
 adapter

On 12/7/21 11:14, Greg KH wrote:
> On Mon, Dec 06, 2021 at 10:22:58AM +0100, Michael Straube wrote:
>> adapter->HalData is used in the GET_HAL_DATA macro all across the
>> driver code but nobody checks if its allocation in
>> rtl188eu_alloc_haldata() was successful or not.
>>
>> To avoid errors when the allocation fails convert the type of field
>> HalData from void pointer to struct hal_data_8188eu. Remove
>> GET_HAL_DATA, rtl8188eu_alloc_haldata(), rtl8188e_free_hal_data().
>>
>> Signed-off-by: Michael Straube <straube.linux@...il.com>
>> ---
>> Tested on x86_64 with InterTech DMG-02.
> 
> This doesn't apply to my tree anymore, due to the other changes that
> were submitted for this driver.  Can you rebase and resend please?
> 

Sure, I'll do.

Thanks,
Michael