linux-kernel - Re: [PATCH] iwlwifi: work around reverse dependency on MEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1uMmgKw=drPhJWCdatzbm1+9FPZ6=-YMme+9n+f3xuXQ@mail.gmail.com>
Date:   Tue, 7 Dec 2021 15:10:08 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Ayala Beker <ayala.beker@...el.com>,
        Miri Korenblit <miriam.rachel.korenblit@...el.com>,
        Johannes Berg <johannes.berg@...el.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: work around reverse dependency on MEI

On Tue, Dec 7, 2021 at 1:54 PM Arnd Bergmann <arnd@...nel.org> wrote:
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index cf1125d84929..474afc6f82a8 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -93,10 +93,10 @@ config IWLWIFI_BCAST_FILTERING
>           expect incoming broadcasts for their normal operations.
>
>  config IWLMEI
> -       tristate "Intel Management Engine communication over WLAN"
> -       depends on INTEL_MEI
> +       bool "Intel Management Engine communication over WLAN"
> +       depends on INTEL_MEI=y || INTEL_MEI=IWLMVM
> +       depends on IWLMVM=y || IWLWIFI=m

For reference, that line is wrong, and I still see the same problem
with my patch
applied. It should work after changing it to

        depends on IWLMVM=y || IWLMVM=m

but I'm still testing for further problems.

             Arnd