linux-kernel - Re: [PATCH v3 net 1/1] net: mvpp2: fix XDP rx queues registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Dec 2021 15:22:54 +0100
From:   Emmanuel Deloget <emmanuel.deloget@....link>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Jakub Kicinski <kuba@...nel.org>, Louis Amas <louis.amas@....link>,
        Marcin Wojtas <mw@...ihalf.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        Matteo Croce <mcroce@...rosoft.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v3 net 1/1] net: mvpp2: fix XDP rx queues registering

Hello,

On 06/12/2021 23:32, Russell King (Oracle) wrote:
> On Mon, Dec 06, 2021 at 11:14:38PM +0100, Emmanuel Deloget wrote:
>> Hello,
>>
>> On 06/12/2021 21:55, Jakub Kicinski wrote:
>>> On Mon,  6 Dec 2021 18:22:19 +0100 Louis Amas wrote:
>>>> The registration of XDP queue information is incorrect because the
>>>> RX queue id we use is invalid. When port->id == 0 it appears to works
>>>> as expected yet it's no longer the case when port->id != 0.
>>>>
>>>> The problem arised while using a recent kernel version on the
>>>> MACCHIATOBin. This board has several ports:
>>>>    * eth0 and eth1 are 10Gbps interfaces ; both ports has port->id == 0;
>>>>    * eth2 is a 1Gbps interface with port->id != 0.
>>>
>>> Still doesn't apply to net/master [1]. Which tree is it based on?
>>> Perhaps you are sending this for the BPF tree? [2] Hm, doesn't apply
>>> there either...
>>>
>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
>>> [2] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/
>>
>> Strange...
>>
>> AFAIK the commit was added on top of net/master (as cloned at approximately
>> 17:30 CET). I'll check with Louis tomorrow morning. We may have messed-up
>> something.
> 
> The reason it doesn't apply is because something is butchering the
> whitespace. Whatever it is, it thinks it knows better than you do,
> and is converting the tabs in the patch to a series of space
> characters. Your email also appears to be using quoted-printable
> encoding.
> 
> It looks like you're using git-send-email - and that should be fine.
> It also looks like you're sending through a MS Exchange server...
> My suspicion would be that the MS Exchange server is re-encoding
> to quoted-printable and is butchering the white space, but that's
> just a guess. I've no idea what you can do about that.


Thanks for you help on this issue. It appears that a configuration hook 
that was applied on our instance was doing extensive modification of the 
mail in order to add a banner at the end of the message. We removed it 
in order to save whitespaces from a gruesome mutilation so it should be 
ok now.

Louis is sending v4 of the patch as we speak.

Best regards,

-- Emmanuel Deloget