linux-kernel - Re: [PATCH] iwlwifi: work around reverse dependency on MEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0dPZDSN_C9-J4k0oFFh4z+XSa64D_R0EhYwBBFQLV8vg@mail.gmail.com>
Date:   Tue, 7 Dec 2021 15:56:56 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "Coelho, Luciano" <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Beker, Ayala" <ayala.beker@...el.com>,
        "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: work around reverse dependency on MEI

On Tue, Dec 7, 2021 at 3:40 PM Johannes Berg <johannes@...solutions.net> wrote:
>
> On Tue, 2021-12-07 at 14:25 +0100, Arnd Bergmann wrote:
>
> > > >  config IWLMEI
> > > > -     tristate "Intel Management Engine communication over WLAN"
> > > > -     depends on INTEL_MEI
> > > > +     bool "Intel Management Engine communication over WLAN"
> > > > +     depends on INTEL_MEI=y || INTEL_MEI=IWLMVM
> > > > +     depends on IWLMVM=y || IWLWIFI=m
> > > >       depends on PM
> > > > -     depends on IWLMVM
> > > >       help
> > > >         Enables the iwlmei kernel module.
> > >
> > > Johannes suggested to make IWLMVM depend on IWLMEI || !IWLMEI
> > > That worked as well, I just had issues with this in our internal backport based tree.
> > > I need to spend a bit more time on this, but I admit my total ignorance in Kconfig's dialect.
> >
> > It's still not enough, the dependency is in iwlwifi, not in iwlmvm, so it
> > would remain broken for IWLWIFI=y IWLMVM=m IWLMEI=m.
> >
>
> I missed the pcie/trans.c dependency, and the others are (I think) in
> mvm...
>
> but then we can do
>
> config IWLWIFI
>         ...
>         depends on IWLMEI || !IWLMEI
>         ...
>
> no? That way, we exclude IWLWIFI=y && IWLMEI=m, which I believe causes
> the issue? And IWLMVM already depends on IWLWIFI (via the if clause), so
> that

Right, that should work. Testing with that version now.

         Arnd