linux-kernel - RE: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Dec 2021 18:07:45 +0000
From:   "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>
To:     José Expósito <jose.exposito89@...il.com>,
        "Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>
CC:     "dledford@...hat.com" <dledford@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

> Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
> 
> Addresses-Coverity-ID: 1493352 ("Resource leak")
> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
>  drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c
> b/drivers/infiniband/hw/qib/qib_user_sdma.c
> index ac11943a5ddb..bf2f30d67949 100644
> --- a/drivers/infiniband/hw/qib/qib_user_sdma.c
> +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
> @@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct
> qib_devdata *dd,
>  					       &addrlimit) ||
>  			    addrlimit > type_max(typeof(pkt->addrlimit))) {
>  				ret = -EINVAL;
> -				goto free_pbc;
> +				goto free_pkt;
>  			}
>  			pkt->addrlimit = addrlimit;
> 
> --
Thanks for catching my mistake!

Mike

Acked-by: Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"):