linux-kernel - Re: [RFC PATCH 1/2] security: Remove security_add_mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Dec 2021 13:41:31 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     David Howells <dhowells@...hat.com>
Cc:     viro@...iv.linux.org.uk, anna.schumaker@...app.com,
        kolga@...app.com, casey@...aufler-ca.com, selinux@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-cachefs@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] security: Remove security_add_mnt_opt() as it's unused

On Wed, Dec 8, 2021 at 1:25 PM David Howells <dhowells@...hat.com> wrote:
>
> Remove the add_mnt_opt LSM hook as it's not actually used.  This makes it
> easier to make the context pointers in selinux_mnt_opts non-const.
>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Alexander Viro <viro@...iv.linux.org.uk>
> cc: Paul Moore <paul@...l-moore.com>
> cc: Casey Schaufler <casey@...aufler-ca.com>
> cc: selinux@...r.kernel.org
> cc: linux-security-module@...r.kernel.org
> cc: linux-nfs@...r.kernel.org
> cc: linux-cachefs@...hat.com
> ---
>
>  include/linux/lsm_hook_defs.h |    2 --
>  include/linux/lsm_hooks.h     |    2 --
>  include/linux/security.h      |    8 --------
>  security/security.c           |    8 --------
>  security/selinux/hooks.c      |   39 ---------------------------------------
>  5 files changed, 59 deletions(-)

There is already a patch in the selinux/next tree which does this.

  commit 52f982f00b220d097a71a23c149a1d18efc08e63
  Author: Ondrej Mosnacek <omosnace@...hat.com>
  Date:   Mon Dec 6 14:24:06 2021 +0100

   security,selinux: remove security_add_mnt_opt()

   Its last user has been removed in commit f2aedb713c28 ("NFS: Add
   fs_context support.").

   Signed-off-by: Ondrej Mosnacek <omosnace@...hat.com>
   Reviewed-by: Casey Schaufler <casey@...aufler-ca.com>
   Signed-off-by: Paul Moore <paul@...l-moore.com>

-- 
paul moore
www.paul-moore.com