linux-kernel - Re: [PATCH] clk: qcom: gcc-msm8974: Modernize the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8792e6d6-f5a2-3055-8011-4a2f5deb0220@gmail.com>
Date:   Wed, 8 Dec 2021 21:07:38 +0200
From:   Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-clk@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-msm8974: Modernize the driver

Hi Bjorn, thanks for the review!

> "xo_board" is actually the crystal feeding the PMIC with a reference
> clock, of interest here is that this is split up in the 2 digital and 3
> analog RPM_SMD_CX_{Dx,Ay} clocks. Out of these you have RPM_SMD_CXO_D0
> being wired up on the CXO pin on the msm8974.
> 
> Back when this was devices we didn't have the means of dealing with
> rpmcc as parent to gcc, so you can in gcc_msm8974_probe() find the
> registration of a clock "xo" which is a 19.2MHz clock parented by
> "xo_board".
> 
> As such, the appropriate .name here would be "xo".
> 
> Likewise "xo" (or actually "cxo") would be a better name for the
> DT-based input clock - and it should point to &rpmcc RPM_SMD_CXO_D0
> (iiuc).

I'll try to fix the mentioned issue and send a v2 in series of patches
with other gcc-msm8974 improvements.

Regards,
Ivaylo