linux-kernel - Re: [PATCH v7 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211208205853.GA25739@Asurada-Nvidia>
Date:   Wed, 8 Dec 2021 12:58:54 -0800
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>
CC:     <thierry.reding@...il.com>, <joro@...tes.org>, <will@...nel.org>,
        <vdumpa@...dia.com>, <jonathanh@...dia.com>,
        <linux-tegra@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 6/6] iommu/tegra-smmu: Add pagetable mappings to
 debugfs

On Wed, Dec 08, 2021 at 07:09:37PM +0300, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 08.12.2021 11:47, Nicolin Chen пишет:
> >  static void tegra_smmu_attach_as(struct tegra_smmu *smmu,
> >                                struct tegra_smmu_as *as,
> >                                unsigned int swgroup)
> > @@ -517,6 +646,12 @@ static void tegra_smmu_attach_as(struct tegra_smmu *smmu,
> >                       dev_warn(smmu->dev,
> >                                "overwriting group->as for swgroup: %s\n", swgrp->name);
> >               group->as = as;
> > +
> > +             if (smmu->debugfs_mappings)
> > +                     debugfs_create_file(group->swgrp->name, 0444,
> > +                                         smmu->debugfs_mappings, group,
> > +                                         &tegra_smmu_debugfs_mappings_fops);
> 
> I noticed this in KMSG:
> 
>  tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2
>  debugfs: File 'g2' in directory 'mappings' already present!
>  tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2
>  debugfs: File 'g2' in directory 'mappings' already present
> 
> Doesn't look okay, please fix.

Thanks for testing and reporting!

I will see and fix it along with your other comments.