linux-kernel - Re: [PATCH v3 2/3] dt-bindings: mmc: Add bindings for LiteSDCard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1639004806.166681.596177.nullmailer@robh.at.kernel.org>
Date:   Wed, 08 Dec 2021 17:06:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     Gabriel Somlo <gsomlo@...il.com>
Cc:     linux-kernel@...r.kernel.org, kgugala@...micro.com,
        mdudek@...ernships.antmicro.com, rdunlap@...radead.org,
        paulus@...abs.org, joel@....id.au, geert@...ux-m68k.org,
        david.abdurachmanov@...ive.com, florent@...oy-digital.fr,
        linux-mmc@...r.kernel.org, shorne@...il.com,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        krakoczy@...micro.com, ulf.hansson@...aro.org,
        mholenko@...micro.com
Subject: Re: [PATCH v3 2/3] dt-bindings: mmc: Add bindings for LiteSDCard

On Wed, 08 Dec 2021 08:20:41 -0500, Gabriel Somlo wrote:
> LiteSDCard is a small footprint, configurable SDCard core for FPGA
> based system on chips.
> 
> Signed-off-by: Gabriel Somlo <gsomlo@...il.com>
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> 
> New in v3:
>   - picked up r/b Geert Uytterhoeven <geert@...ux-m68k.org> in DT
>     bindings document (please let me know if that was premature, and
>     happy to take further review if needed :)
>   - add dedicated DT property for source clock frequency
> 
>  .../devicetree/bindings/mmc/litex,mmc.yaml    | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/litex,mmc.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml: properties:reg-names:items: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'phy'}, {'const': 'core'}, {'const': 'reader'}, {'const': 'writer'}, {'const': 'irq (optional)'}] is not of type 'object'
	'irq (optional)' does not match '^[a-zA-Z0-9,.\\-_ #+/]+$'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml: properties:reg: {'items': [{'description': 'PHY registers'}, {'description': 'CORE registers'}, {'description': 'DMA Reader buffer'}, {'description': 'DMA Writer buffer'}, {'description': 'IRQ registers (optional)'}], 'minItems': 4, 'maxItems': 5} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml: properties:reg-names: {'items': [{'const': 'phy'}, {'const': 'core'}, {'const': 'reader'}, {'const': 'writer'}, {'const': 'irq (optional)'}], 'minItems': 4, 'maxItems': 5} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml: ignoring, error in schema: properties: reg-names: items
warning: no schema found in file: ./Documentation/devicetree/bindings/mmc/litex,mmc.yaml
Documentation/devicetree/bindings/mmc/litex,mmc.example.dt.yaml:0:0: /example-0/mmc@...05000: failed to match any schema with compatible: ['litex,mmc']

doc reference errors (make refcheckdocs):


See https://patchwork.ozlabs.org/patch/1565210

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.