linux-kernel - Re: [PATCH -V10 RESEND 1/6] NUMA Balancing: add page promotion counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871r2n4z9t.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Wed, 08 Dec 2021 10:16:14 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Hasan Al Maruf <hasan3050@...il.com>
Cc:     akpm@...ux-foundation.org, dave.hansen@...ux.intel.com,
        feng.tang@...el.com, hasanalmaruf@...com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, mgorman@...e.de,
        mgorman@...hsingularity.net, mhocko@...e.com, osalvador@...e.de,
        peterz@...radead.org, riel@...riel.com, shakeelb@...gle.com,
        shy828301@...il.com, weixugc@...gle.com, ziy@...dia.com
Subject: Re: [PATCH -V10 RESEND 1/6] NUMA Balancing: add page promotion counter

Hasan Al Maruf <hasan3050@...il.com> writes:

> Hi Huang,
>
>>+#ifdef CONFIG_NUMA_BALANCING
>>+	PGPROMOTE_SUCCESS,	/* promote successfully */
>
> I find a breakdown of Anon and File page promotion can often be useful to
> understand an application's behavior (i.e. what kind of pages are moved to
> remote node and later being promoted). What do you think about adding
> counters for such a breakdown?
>
> What's your thought on adding counters for failures on different reasons?

I think that all these provide helpful information.  But I think that we
can add them in separate patches.  That will make reviewing simpler.

Best Regards,
Huang, Ying