linux-kernel - Re: [PATCH 2/2] wilc1000: Fix missing newline in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b44cebddcda765942aa118d25740a074137d0f8.camel@perches.com>
Date:   Tue, 07 Dec 2021 16:23:18 -0800
From:   Joe Perches <joe@...ches.com>
To:     David Mosberger-Tang <davidm@...uge.net>,
        Ajay Singh <ajay.kathat@...rochip.com>
Cc:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] wilc1000: Fix missing newline in error message

On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote:
> On 12/6/21 6:33 PM, Joe Perches wrote:
> 
> > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
> > > Add missing newline in pr_err() message.
> > []
> > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
> > []
> > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
> > >   	struct wilc *wilc = user_data;
> > >   
> > >   	if (wilc->close) {
> > > -		pr_err("Can't handle UH interrupt");
> > > +		pr_err("Can't handle UH interrupt\n");
> > Ideally this would use wiphy_<level>:
> > 
> > 		wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");
> 
> Sure, but that's orthogonal to this bug fix.

Of course.

> I do have a "cleanups" 
> branch with various cleanups of this sort.  I'll look into fixing pr_*() 
> calls in the cleanups branch (there are several of them, unsurprisingly).

netdev_<level> -> wiphy_<level> conversions too where feasible please.