linux-kernel - Re: [PATCH] cifs: Fix crash on unload of cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mtxkO9whCCKrFXMYNr26RcShx-QT4_EZvLJj52AkQjWqw@mail.gmail.com>
Date:   Tue, 7 Dec 2021 22:33:10 -0600
From:   Steve French <smfrench@...il.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     Steve French <sfrench@...ba.org>,
        Namjae Jeon <linkinjeon@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Hyunchul Lee <hyc.lee@...il.com>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        kernel <kernel@...s.com>, Steve French <stfrench@...rosoft.com>
Subject: Re: [PATCH] cifs: Fix crash on unload of cifs_arc4.ko

merged into cifs-2.6.git for-next

On Tue, Dec 7, 2021 at 6:11 AM Vincent Whitchurch via samba-technical
<samba-technical@...ts.samba.org> wrote:
>
> The exit function is wrongly placed in the __init section and this leads
> to a crash when the module is unloaded.  Just remove both the init and
> exit functions since this module does not need them.
>
> Fixes: 71c02863246167b3d ("cifs: fork arc4 and create a separate module...")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>
> ---
>  fs/smbfs_common/cifs_arc4.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/fs/smbfs_common/cifs_arc4.c b/fs/smbfs_common/cifs_arc4.c
> index 85ba15a60b13..043e4cb839fa 100644
> --- a/fs/smbfs_common/cifs_arc4.c
> +++ b/fs/smbfs_common/cifs_arc4.c
> @@ -72,16 +72,3 @@ void cifs_arc4_crypt(struct arc4_ctx *ctx, u8 *out, const u8 *in, unsigned int l
>         ctx->y = y;
>  }
>  EXPORT_SYMBOL_GPL(cifs_arc4_crypt);
> -
> -static int __init
> -init_smbfs_common(void)
> -{
> -       return 0;
> -}
> -static void __init
> -exit_smbfs_common(void)
> -{
> -}
> -
> -module_init(init_smbfs_common)
> -module_exit(exit_smbfs_common)
> --
> 2.33.1
>
>


-- 
Thanks,

Steve