linux-kernel - RE: [PATCH net-next v4 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5fe14be8d2434793713bd13abccb28@sphcmbx02.sunplus.com.tw>
Date:   Wed, 8 Dec 2021 04:37:59 +0000
From:   Wells Lu 呂芳騰 <wells.lu@...plus.com>
To:     Jakub Kicinski <kuba@...nel.org>, Wells Lu <wellslutw@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Vincent Shih 施錕鴻 <vincent.shih@...plus.com>
Subject: RE: [PATCH net-next v4 2/2] net: ethernet: Add driver for Sunplus
 SP7021

Hi Jakub,

Thank you for review.

I'll fix the warnings reported from clang next patch.


Best regards,
Wells Lu


> On Tue,  7 Dec 2021 16:06:59 +0800 Wells Lu wrote:
> > Add driver for Sunplus SP7021 SoC.
> >
> > Signed-off-by: Wells Lu <wellslutw@...il.com>
> 
> clang points out:
> 
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:65: warning: result of comparison of
> constant 188 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
>             (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
>                                                            ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:19: warning: result of comparison of
> constant 252 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
>             (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
>              ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:64: warning: result of comparison of
> constant 188 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
>         if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
>                                                           ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:18: warning: result of comparison of
> constant 252 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
>         if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
>             ~~~~~~~~~~~ ^  ~~~~