linux-kernel - Re: [PATCH] MIPS: Loongson64: Use three arguments for slti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faadff42-e769-cc8b-5ae2-793b2c006b91@omp.ru>
Date:   Wed, 8 Dec 2021 11:55:59 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Nathan Chancellor <nathan@...nel.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
CC:     Nick Desaulniers <ndesaulniers@...gle.com>,
        <linux-mips@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <llvm@...ts.linux.dev>,
        Ryutaroh Matsumoto <ryutaroh@....e.titech.ac.jp>
Subject: Re: [PATCH] MIPS: Loongson64: Use three arguments for slti

Hello!

On 07.12.2021 20:01, Nathan Chancellor wrote:

> LLVM's integrated assembler does not support 'stli <reg>, <imm>':

    Perhaps slti (as below)?

> <instantiation>:16:12: error: invalid operand for instruction
>   slti $12, (0x6300 | 0x0008)
>             ^
> arch/mips/kernel/head.S:86:2: note: while in macro instantiation
>   kernel_entry_setup # cpu specific setup
>   ^
> <instantiation>:16:12: error: invalid operand for instruction
>   slti $12, (0x6300 | 0x0008)
>             ^
> arch/mips/kernel/head.S:150:2: note: while in macro instantiation
>   smp_slave_setup
>   ^
> 
> To increase compatibility with LLVM's integrated assembler, use the full
> form of 'stli <reg>, <reg>, <imm>', which matches the rest of

    Again, slti?

> arch/mips/. This does not result in any change for GNU as.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/1526
> Reported-by: Ryutaroh Matsumoto <ryutaroh@....e.titech.ac.jp>
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
[...]

MBR, Sergey