linux-kernel - Re: [PATCH v10 0/3] Add driver for lan966x Generic Clock Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8198b69e-44ba-3636-c02f-115c7851a664@microchip.com>
Date:   Wed, 8 Dec 2021 11:10:14 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>,
        <robh+dt@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, "Claudiu Beznea" <Claudiu.Beznea@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <Eugen.Hristev@...rochip.com>, <Manohar.Puri@...rochip.com>
Subject: Re: [PATCH v10 0/3] Add driver for lan966x Generic Clock Controller

On 03/11/2021 at 07:19, Kavyasree Kotagiri wrote:
> This patch series adds a device driver for Generic Clock Controller
> of lan966x SoC.
> 
> v9 -> v10:
> - Removed .name from lan966x_gck_pdata struct.
> - Removed "_clk" in fw_names like used in bindings
> 
> v8 -> v9:
> - Added Acked-by to dt-bindings and Documentation file.
> - Changed clk_name "timer" to "timer1"
> - Updated devm_kzalloc in probe function.
> 
> v7 -> v8:
> - Defined new constant DIV_MAX.
> - Corrected and updated prescaler divider condition check.
> - Added Acked-by.
> 
> v6 -> v7:
> - Added Kconfig and Makefile entires for lan966x clock driver.
> 
> v5 -> v6:
> - Added Acked-by to dt-bindings file.
> - Removed "_clk" in clock-names.
> - Added Reviewed-by to Documentation file.
> 
> v4 -> v5:
> - In v4 dt-bindings, missed adding "clock-names" in required
>    properties and example. So, added them.
> - Returning proper error - PTR_ERR.
> - Removed unused variable "ret" in probe function.
> 
> v3 -> v4:
> - Updated "clocks" and added "clock-names" in dt-bindings.
> - Used clk_parent_data instead of of_clk_get_parent_name().
> 
> v2 -> v3:
> - Fixed dt_binding_check errors.
> 
> v1 -> v2:
> - Updated license in dt-bindings.
> - Updated example provided for clock controller node.
> 
> Kavyasree Kotagiri (3):
>    dt-bindings: clock: lan966x: Add binding includes for lan966x SoC
>      clock IDs
>    dt-bindings: clock: lan966x: Add LAN966X Clock Controller
>    clk: lan966x: Add lan966x SoC clock driver

3 patches added in clk-at91 branch which will be merged in at91-next 
consumed by linux-next.

I plan to issue a PR for at91 clock patches soon.

Best regards,
   Nicolas

>   .../bindings/clock/microchip,lan966x-gck.yaml |  57 +++++
>   drivers/clk/Kconfig                           |   7 +
>   drivers/clk/Makefile                          |   1 +
>   drivers/clk/clk-lan966x.c                     | 240 ++++++++++++++++++
>   include/dt-bindings/clock/microchip,lan966x.h |  28 ++
>   5 files changed, 333 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
>   create mode 100644 drivers/clk/clk-lan966x.c
>   create mode 100644 include/dt-bindings/clock/microchip,lan966x.h
> 


-- 
Nicolas Ferre