[<prev] [next>] [day] [month] [year] [list]
Message-Id: <cd3a382dc39e72229a73149cb91e80cf69e2b07d.1638958947.git.mchehab+huawei@kernel.org>
Date: Wed, 8 Dec 2021 11:25:30 +0100
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@...wei.com, mauro.chehab@...wei.com,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
Antti Palosaari <crope@....fi>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Robert Schlabbach <robert_s@....net>,
Olli Salonen <olli.salonen@....fi>,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: [PATCH RFC] media: si2157: optionally load firmare for SI2146_A10 and
Cc: Antti Palosaari <crope@....fi>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Robert Schlabbach <robert_s@....net>
Cc: Olli Salonen <olli.salonen@....fi>
Cc: linux-kernel@...r.kernel.org
Cc: linux-media@...r.kernel.org
While the eeprom firmware files for such devices are know to work,
if there is a firmware file, use it instead, as a newer version
could have solved some tuning issues.
Compile-tested only.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
---
At least on my eyes, it makes sense to also allow to optionally load A10
and A30 firmware files for SI2146_A10 and SI147_A30.
Yet, before applying this one, someone needs to report that those devices
will keep working with the loaded firmware files.
drivers/media/tuners/si2157.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
index 5f4ae8593864..f970bedfb179 100644
--- a/drivers/media/tuners/si2157.c
+++ b/drivers/media/tuners/si2157.c
@@ -205,19 +205,19 @@ static int si2157_init(struct dvb_frontend *fe)
case SI2148_A20:
fw_name = SI2158_A20_FIRMWARE;
break;
+ case SI2146_A10:
+ fw_required = false;
+ fallthrough;
case SI2141_A10:
fw_name = SI2141_A10_FIRMWARE;
break;
+ case SI2147_A30:
case SI2157_A30:
fw_required = false;
fallthrough;
case SI2177_A30:
fw_name = SI2157_A30_FIRMWARE;
break;
- case SI2147_A30:
- case SI2146_A10:
- fw_name = NULL;
- break;
default:
dev_err(&client->dev, "unknown chip version Si21%d-%c%c%c\n",
cmd.args[2], cmd.args[1],
--
2.33.1
Powered by blists - more mailing lists