linux-kernel - Re: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211208121000.GG4216@dragon>
Date:   Wed, 8 Dec 2021 20:10:00 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     robh+dt@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, ping.bai@....com,
        aisheng.dong@....com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node

On Wed, Nov 17, 2021 at 11:27:39AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> i.MX8ULP use scmi firmware based power domain and sensor support.
> So add the firmware node and the sram it uses.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index fb8714379026..d567ef93f8d8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -6,6 +6,7 @@
>  #include <dt-bindings/clock/imx8ulp-clock.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/imx8ulp-power.h>
>  
>  #include "imx8ulp-pinfunc.h"
>  
> @@ -102,6 +103,40 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> +	sram@...1f000 {
> +		compatible = "mmio-sram";
> +		reg = <0x0 0x2201f000 0x0 0x1000>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0 0x0 0x2201f000 0x1000>;
> +
> +		scmi_buf: scmi_buf@0 {

Hyphen is more recommended than underscore for node name.  Or just
follow the naming in arm,scmi.yaml example?

Shawn

> +			compatible = "arm,scmi-shmem";
> +			reg = <0x0 0x400>;
> +		};
> +	};
> +
> +	firmware {
> +		scmi {
> +			compatible = "arm,scmi-smc";
> +			arm,smc-id = <0xc20000fe>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			shmem = <&scmi_buf>;
> +
> +			scmi_devpd: protocol@11 {
> +				reg = <0x11>;
> +				#power-domain-cells = <1>;
> +			};
> +
> +			scmi_sensor: protocol@15 {
> +				reg = <0x15>;
> +				#thermal-sensor-cells = <0>;
> +			};
> +		};
> +	};
> +
>  	soc@0 {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
> -- 
> 2.25.1
>