linux-kernel - Re: [PATCH] mmc: bus: Log bus width info when attaching card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac0cdefbd2a43329b50a803b7c46959@hyperstone.com>
Date:   Wed, 8 Dec 2021 13:03:46 +0000
From:   Christian Löhle <CLoehle@...erstone.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Christian Löhle <CLoehle@...erstone.com>
CC:     "johan@...nel.org" <johan@...nel.org>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "linux@...inikbrodowski.net" <linux@...inikbrodowski.net>
Subject: Re: [PATCH] mmc: bus: Log bus width info when attaching card

Might seem unecessary to print the bus width and a bit confusing, but it is the only 'bus info' that is not printed in that line.
So I suggest adding it.

Regards,
Christian




From: Christian Löhle
Sent: Wednesday, December 8, 2021 2:02 PM
To: linux-kernel@...r.kernel.org; linux-mmc@...r.kernel.org; Ulf Hansson; Christian Löhle
Cc: johan@...nel.org; sudeep.holla@....com; linux@...inikbrodowski.net
Subject: [PATCH] mmc: bus: Log bus width info when attaching card
    
Add info about bus width of the attached card to the bring-up message

For both MMC and SD cards the bus width that is used might
not be obvious to a user. For MMC this might be 1, 4 or 8,
for SD only 1 and 4. In both cases this would be a restriction
by the host (setup). Like using an MMC in an SD slot or an
eMMC to SD adapter.

Signed-off-by: Christian Loehle <cloehle@...erstone.com>
---
 drivers/mmc/core/bus.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
index f6b7a9c5bbff..71a675dcd9b7 100644
--- a/drivers/mmc/core/bus.c
+++ b/drivers/mmc/core/bus.c
@@ -358,7 +358,7 @@ int mmc_add_card(struct mmc_card *card)
                         mmc_card_ddr52(card) ? "DDR " : "",
                         type);
         } else {
-               pr_info("%s: new %s%s%s%s%s%s card at address %04x\n",
+               pr_info("%s: new %s%s%s%s%s%s %u-bit card at address %04x\n",
                         mmc_hostname(card->host),
                         mmc_card_uhs(card) ? "ultra high speed " :
                         (mmc_card_hs(card) ? "high speed " : ""),
@@ -366,7 +366,8 @@ int mmc_add_card(struct mmc_card *card)
                         (mmc_card_hs200(card) ? "HS200 " : ""),
                         mmc_card_hs400es(card) ? "Enhanced strobe " : "",
                         mmc_card_ddr52(card) ? "DDR " : "",
-                       uhs_bus_speed_mode, type, card->rca);
+                       uhs_bus_speed_mode, type,
+                       1<<card->host->ios.bus_width, card->rca);
         }
 
 #ifdef CONFIG_DEBUG_FS
-- 
2.34.1
    =
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782