linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff254ab5-1d57-3aea-1232-4f26766eeb62@microchip.com>
Date:   Wed, 8 Dec 2021 14:06:26 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Eugen Hristev - M18282 <Eugen.Hristev@...rochip.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "Ludovic Desroches - M43218" <Ludovic.Desroches@...rochip.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mihai Sain - M19926 <Mihai.Sain@...rochip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove
 PA11__SDMMC0_VDDSEL from pinctrl

On 08/12/2021 at 12:27, Eugen Hristev - M18282 wrote:
> On 12/8/21 1:22 PM, Nicolas Ferre wrote:
>> On 26/10/2021 at 15:20, Eugen Hristev wrote:
>>> From: Mihai Sain <mihai.sain@...rochip.com>
>>>
>>> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
>>> tied with 10K resistor to GND. U13 switch S1 is always selected as
>>> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC
>>> flash.
>>> Removing PA11 from pinctrl because it remains unused.
>>>
>>> Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> 
> You can also add my
> Reviewed-by: Eugen Hristev <eugen.hristev@...rochip.com>
> 
> and also
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>
> because I sent the patch.

Sure Eugen: Done. Best regards,
   Nicolas

>>> ---
>>>    arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> index b1e854f658de..9bf2ec0ba3e2 100644
>>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@...00000 {
>>>                pinctrl-names = "default";
>>>                pinctrl-0 = <&pinctrl_sdmmc0_default>;
>>>                non-removable;
>>> -            mmc-ddr-1_8v;
>>> +            mmc-ddr-3_3v;
>>>                status = "okay";
>>>            };
>>> @@ -619,10 +619,9 @@ cmd_data {
>>>                            bias-disable;
>>>                        };
>>> -                    ck_cd_rstn_vddsel {
>>> +                    ck_cd_rstn {
>>>                            pinmux = <PIN_PA0__SDMMC0_CK>,
>>>                                 <PIN_PA10__SDMMC0_RSTN>,
>>> -                             <PIN_PA11__SDMMC0_VDDSEL>,
>>>                                 <PIN_PA13__SDMMC0_CD>;
>>>                            bias-disable;
>>>                        };
>>>
>>
>>
> 


-- 
Nicolas Ferre