linux-kernel - Re: [net-next RFC PATCH v2 7/8] net: dsa: qca8k: Add support for mdio read/write in Ethernet packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211208144254.sisj4sglcpzmkwz5@skbuf>
Date:   Wed, 8 Dec 2021 16:42:54 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [net-next RFC PATCH v2 7/8] net: dsa: qca8k: Add support for
 mdio read/write in Ethernet packet

On Wed, Dec 08, 2021 at 03:21:11PM +0100, Ansuel Smith wrote:
> > None of these structures need to stay in the data structure shared with
> > the tagger. They can be in qca8k_priv. The tagger should only see the
> > function pointers. It doesn't care what is done with the packets.
> > 
> > >  };
> 
> Ok so the handler should access these data by reaching the qca8k_priv
> from the dsa port. Correct?

Yes, this is exactly what I think, the tagger should be stateless with
regard to the completion, if it can be stateless. Only with stuff
related to the tagging protocol itself it can be stateful, things like
sequence numbers if you need them, etc. But the MDIO access is payload
as far as the tagger is concerned.