linux-kernel - Re: [PATCH] binder: fix pointer cast warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Dec 2021 06:59:49 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Christian Brauner <christian.brauner@...ntu.com>,
        Arnd Bergmann <arnd@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Arnd Bergmann <arnd@...db.de>, Li Li <dualli@...gle.com>,
        Marco Ballesio <balejs@...gle.com>,
        Hang Lu <hangl@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: fix pointer cast warning



On 12/8/21 02:09, Christian Brauner wrote:
> On Tue, Dec 07, 2021 at 01:24:42PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> binder_uintptr_t is not the same as uintptr_t, so converting it into a
>> pointer requires a second cast:
>>
>> drivers/android/binder.c: In function 'binder_translate_fd_array':
>> drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>>  2511 |         sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
>>       |                            ^
>>
>> Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
> 
> Looks good.
> Acked-by: Christian Brauner <christian.brauner@...ntu.com>
> 

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

thanks.

-- 
~Randy