lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202112091014.OAV9O2tr-lkp@intel.com>
Date:   Thu, 9 Dec 2021 10:31:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: [hare-scsi-devel:ata-trace.v3 13/73]
 drivers/ata/sata_dwc_460ex.c:744:26: error: implicit declaration of function
 'get_dma_dir_descript'; did you mean 'get_prot_descript'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git ata-trace.v3
head:   d973dee7af0328b9176e4a1710fb73093c334698
commit: a8252508eadb132c62be4596a50701e1f261e92d [13/73] sata_dwc_460ex: use generic tracepoints
config: arm-buildonly-randconfig-r005-20211207 (https://download.01.org/0day-ci/archive/20211209/202112091014.OAV9O2tr-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=a8252508eadb132c62be4596a50701e1f261e92d
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel ata-trace.v3
        git checkout a8252508eadb132c62be4596a50701e1f261e92d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/ata/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from drivers/ata/sata_dwc_460ex.c:28:
   drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_xfer_complete':
>> drivers/ata/sata_dwc_460ex.c:744:26: error: implicit declaration of function 'get_dma_dir_descript'; did you mean 'get_prot_descript'? [-Werror=implicit-function-declaration]
     744 |                          get_dma_dir_descript(qc->dma_dir),
         |                          ^~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                                     ^~~~~~~~~~~
   drivers/ata/sata_dwc_460ex.c:741:17: note: in expansion of macro 'dev_info'
     741 |                 dev_info(ap->dev,
         |                 ^~~~~~~~
>> drivers/ata/sata_dwc_460ex.c:742:26: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'int' [-Wformat=]
     742 |                          "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
         |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
     150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                          ^~~~~~~
   drivers/ata/sata_dwc_460ex.c:741:17: note: in expansion of macro 'dev_info'
     741 |                 dev_info(ap->dev,
         |                 ^~~~~~~~
   drivers/ata/sata_dwc_460ex.c:742:57: note: format string is defined here
     742 |                          "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
         |                                                        ~^
         |                                                         |
         |                                                         char *
         |                                                        %d
   cc1: some warnings being treated as errors


vim +744 drivers/ata/sata_dwc_460ex.c

62936009f35a665 Rupjyoti Sarmah 2010-07-06  724  
62936009f35a665 Rupjyoti Sarmah 2010-07-06  725  static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a665 Rupjyoti Sarmah 2010-07-06  726  {
62936009f35a665 Rupjyoti Sarmah 2010-07-06  727  	struct ata_queued_cmd *qc;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  728  	struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06  729  	struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06  730  	u8 tag = 0;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  731  
62936009f35a665 Rupjyoti Sarmah 2010-07-06  732  	tag = ap->link.active_tag;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  733  	qc = ata_qc_from_tag(ap, tag);
62936009f35a665 Rupjyoti Sarmah 2010-07-06  734  	if (!qc) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06  735  		dev_err(ap->dev, "failed to get qc");
62936009f35a665 Rupjyoti Sarmah 2010-07-06  736  		return;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  737  	}
62936009f35a665 Rupjyoti Sarmah 2010-07-06  738  
62936009f35a665 Rupjyoti Sarmah 2010-07-06  739  #ifdef DEBUG_NCQ
62936009f35a665 Rupjyoti Sarmah 2010-07-06  740  	if (tag > 0) {
d578514b271e7c8 Andy Shevchenko 2015-03-03  741  		dev_info(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03 @742  			 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba84 Jens Axboe      2018-05-11  743  			 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28 @744  			 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28  745  			 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa66 Mans Rullgard   2016-04-26  746  			 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06  747  	}
62936009f35a665 Rupjyoti Sarmah 2010-07-06  748  #endif
62936009f35a665 Rupjyoti Sarmah 2010-07-06  749  
62936009f35a665 Rupjyoti Sarmah 2010-07-06  750  	if (ata_is_dma(qc->tf.protocol)) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06  751  		if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c8 Andy Shevchenko 2015-03-03  752  			dev_err(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03  753  				"%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c8 Andy Shevchenko 2015-03-03  754  				__func__,
ee81d6cc8e8aa66 Mans Rullgard   2016-04-26  755  				sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06  756  		}
62936009f35a665 Rupjyoti Sarmah 2010-07-06  757  
62936009f35a665 Rupjyoti Sarmah 2010-07-06  758  		hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  759  		sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06  760  		ap->link.active_tag = ATA_TAG_POISON;
62936009f35a665 Rupjyoti Sarmah 2010-07-06  761  	} else {
62936009f35a665 Rupjyoti Sarmah 2010-07-06  762  		sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06  763  	}
62936009f35a665 Rupjyoti Sarmah 2010-07-06  764  }
62936009f35a665 Rupjyoti Sarmah 2010-07-06  765  

:::::: The code at line 744 was first introduced by commit
:::::: 84b47e3b16f8a5bb416cd55774d679ebbdb19072 sata_dwc_460ex: fix misuse of ata_get_cmd_descript()

:::::: TO: Sergei Shtylyov <sshtylyov@...mvista.com>
:::::: CC: Jeff Garzik <jgarzik@...hat.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ