linux-kernel - Re: [PATCH v14 2/4] dmaengine: tegra: Add tegra gpcdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbI4mtV3npK87c26@orome>
Date:   Thu, 9 Dec 2021 18:10:50 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     dan.j.williams@...el.com, devicetree@...r.kernel.org,
        dmaengine@...r.kernel.org, jonathanh@...dia.com,
        kyarlagadda@...dia.com, ldewangan@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        p.zabel@...gutronix.de, rgumasta@...dia.com, robh+dt@...nel.org,
        vkoul@...nel.org, Pavan Kunapuli <pkunapuli@...dia.com>
Subject: Re: [PATCH v14 2/4] dmaengine: tegra: Add tegra gpcdma driver

On Mon, Dec 06, 2021 at 06:30:37PM +0530, Akhil R wrote:
> Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver
> supports dma transfers between memory to memory, IO peripheral to memory
> and memory to IO peripheral.
> 
> Signed-off-by: Pavan Kunapuli <pkunapuli@...dia.com>
> Signed-off-by: Rajesh Gumasta <rgumasta@...dia.com>
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> Reviewed-by: Jon Hunter <jonathanh@...dia.com>
> ---
>  drivers/dma/Kconfig            |   12 +
>  drivers/dma/Makefile           |    1 +
>  drivers/dma/tegra186-gpc-dma.c | 1284 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1297 insertions(+)
>  create mode 100644 drivers/dma/tegra186-gpc-dma.c
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 80c2c03..35095ae 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -629,6 +629,18 @@ config TXX9_DMAC
>  	  Support the TXx9 SoC internal DMA controller.  This can be
>  	  integrated in chips such as the Toshiba TX4927/38/39.
>  
> +config TEGRA186_GPC_DMA
> +	tristate "NVIDIA Tegra GPC DMA support"
> +	depends on ARCH_TEGRA_186_SOC || ARCH_TEGRA_194_SOC || COMPILE_TEST

I wonder if we want to maybe make this depend on ARCH_TEGRA instead to
avoid having to add dependencies on newer SoCs (presumably Tegra234 will
feature this GPC DMA as well).

Not worth a respin, but perhaps something to consider when adding
Tegra234 support.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)