linux-kernel - Re: [PATCH v4] futex: Clarify comment at futex_wait_multiple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5d23118-f796-9552-cf58-54155a6f347c@collabora.com>
Date:   Thu, 9 Dec 2021 14:18:22 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     6812skiii@...il.com, tglx@...utronix.de, mingo@...hat.com
Cc:     peterz@...radead.org, dvhart@...radead.org, dave@...olabs.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup()

Às 14:14 de 09/12/21, 6812skiii@...il.com escreveu:
> From: Jangwoong Kim <6812skiii@...il.com>
> 

Almost there, this time you forgot to write something here in the commit
description :)

> Signed-off-by: Jangwoong Kim <6812skiii@...il.com>
> ---
>  kernel/futex/waitwake.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
> index 4ce0923f1ce3..c7a14ebfe61d 100644
> --- a/kernel/futex/waitwake.c
> +++ b/kernel/futex/waitwake.c
> @@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *wo
>  		__set_current_state(TASK_RUNNING);
>  
>  		/*
> -		 * Even if something went wrong, if we find out that a futex
> -		 * was woken, we don't return error and return this index to
> -		 * userspace
> +		 * Even if something went wrong, if we find out that any futex
> +		 * was woken, we don't return error and return the index of the
> +		 * last futex awaken to userspace
>  		 */
>  		*woken = unqueue_multiple(vs, i);
>  		if (*woken >= 0)
>