linux-kernel - Re: [PATCH] scsi: docs: update notes about scsi_times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c50efd9-2987-067a-bc05-0a68ad908a5f@acm.org>
Date:   Thu, 9 Dec 2021 11:44:09 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Khazhismel Kumykov <khazhy@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-doc@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH] scsi: docs: update notes about scsi_times_out

On 12/8/21 2:56 PM, Khazhismel Kumykov wrote:
> + 2. scsi_abort_command() is invoked to schedule an asynchrous abort. which may
                                                                       ^^^^^^^
                                                            Should the dot perhaps be removed?
> +    issue a retry scmd->allowed + 1 times.  Asynchronous abort are not invoked
                                                             ^^^^
                                                        abort -> aborts?
> +    for commands which the SCSI_EH_ABORT_SCHEDULED flag is set (this indicates
                     ^^^^^
                 which -> for which?
> +    that the command already had been aborted once, and this is a retry which
> +    failed), when retries are exceeded, or when the EH deadline is expired. In
> +    these case Step #3 is taken.
>   
>    3. scsi_eh_scmd_add(scmd, SCSI_EH_CANCEL_CMD) is invoked for the
>       command.  See [1-4] for more information.

Thanks,

Bart.