linux-kernel - Re: [PATCH v1 1/1] percpu_ref: Replace kernel.h with the necessary inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbJppiVtI+F5Pda1@fedora>
Date:   Thu, 9 Dec 2021 15:40:06 -0500
From:   Dennis Zhou <dennis@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Pavel Begunkov <asml.silence@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Dennis Zhou <dennis@...nel.org>,
        Tejun Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH v1 1/1] percpu_ref: Replace kernel.h with the necessary
 inclusions

Hello,

On Thu, Dec 09, 2021 at 02:30:33PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
> 
> Replace kernel.h inclusion with the list of what is really being used.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/percpu-refcount.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
> index b31d3f3312ce..d73a1c08c3e3 100644
> --- a/include/linux/percpu-refcount.h
> +++ b/include/linux/percpu-refcount.h
> @@ -51,9 +51,9 @@
>  #define _LINUX_PERCPU_REFCOUNT_H
>  
>  #include <linux/atomic.h>
> -#include <linux/kernel.h>
>  #include <linux/percpu.h>
>  #include <linux/rcupdate.h>
> +#include <linux/types.h>
>  #include <linux/gfp.h>
>  
>  struct percpu_ref;
> -- 
> 2.33.0
> 

Applied to for-5.16-fixes.

Thanks,
Dennis