linux-kernel - [PATCH] virtio-pci: fix the confusing error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ae5e154e-ac59-f0fa-a7c7-091a2201f581@linux.alibaba.com>
Date:   Thu, 9 Dec 2021 11:29:25 +0800
From:   王贇 <yun.wang@...ux.alibaba.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "open list:VIRTIO CORE AND NET DRIVERS" 
        <virtualization@...ts.linux-foundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: [PATCH] virtio-pci: fix the confusing error message

The error message on the failure of pfn check should tell
virtio-pci rather than virtio-mmio, just fix it.

Signed-off-by: Michael Wang <yun.wang@...ux.alibaba.com>
Suggested-by: Michael S. Tsirkin <mst@...hat.com>
---
  drivers/virtio/virtio_pci_legacy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_pci_legacy.c 
b/drivers/virtio/virtio_pci_legacy.c
index d62e983..0ede3bf 100644
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -144,7 +144,7 @@ static struct virtqueue *setup_vq(struct 
virtio_pci_device *vp_dev,
  	q_pfn = virtqueue_get_desc_addr(vq) >> VIRTIO_PCI_QUEUE_ADDR_SHIFT;
  	if (q_pfn >> 32) {
  		dev_err(&vp_dev->pci_dev->dev,
-			"platform bug: legacy virtio-mmio must not be used with RAM above 
0x%llxGB\n",
+			"platform bug: legacy virtio-pci must not be used with RAM above 
0x%llxGB\n",
  			0x1ULL << (32 + PAGE_SHIFT - 30));
  		err = -E2BIG;
  		goto out_del_vq;
-- 
1.8.3.1