linux-kernel - Re: ANNOUNCE: pahole v1.23 (BTF tags and alignment inference)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0364fb10-359e-c9c1-f90f-a01be2944dd6@fb.com>
Date:   Thu, 9 Dec 2021 14:09:13 -0800
From:   Yonghong Song <yhs@...com>
To:     Jan Engelhardt <jengelh@...i.de>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     <dwarves@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <bpf@...r.kernel.org>, Jiri Olsa <jolsa@...nel.org>,
        Domenico Andreoli <domenico.andreoli@...ux.com>,
        Matthias Schwarzott <zzam@...too.org>,
        Douglas RAILLARD <douglas.raillard@....com>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        Matteo Croce <mcroce@...rosoft.com>
Subject: Re: ANNOUNCE: pahole v1.23 (BTF tags and alignment inference)



On 12/8/21 11:11 AM, Jan Engelhardt wrote:
> 
> On Wednesday 2021-12-08 19:35, Arnaldo Carvalho de Melo wrote:
> 
>> Em Wed, Dec 08, 2021 at 03:26:31PM +0100, Jan Engelhardt escreveu:
>>>
>>> On Wednesday 2021-12-08 14:54, Arnaldo Carvalho de Melo wrote:
>>>>
>>>> 	The v1.23 release of pahole and its friends is out, this time
>>>> the main new features are the ability to encode BTF tags, to carry
>>>
>>> [    7s] /home/abuild/rpmbuild/BUILD/dwarves-1.23/btf_encoder.c:145:10: error: 'BTF_KIND_DECL_TAG' undeclared here (not in a function); did you mean 'BTF_KIND_FLOAT'?
>>>
>>> libbpf-0.5.0 is present, since CMakeLists.txt checked for >= 0.4.0.
>>
>> My fault, knowing the flux that libbpf is in getting to 1.0 I should
>> have retested with the perf tools container based tests.
>>
>> Can you think about some fix for that? Lemme see if BTF_KIND_DECL_TAG is
>> a define or an enum...
> 
> Just bumping this line
> 
>                  pkg_check_modules(LIBBPF REQUIRED libbpf>=0.4.0)
> 
> to the right version would absolutely be sufficient for us. Of course, that
> requires that the libbpf project itself at least manages to make tags
> regularly.

Change above version 0.4.0 to 0.6.0 should work as libbpf 0.6.0 contains
all the changes related to BTF_KIND_{TYPE,DECL}_TAGs.