linux-kernel - Re: [PATCH] scsi: elx: efct: Avoid a useless memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52c4bc82-f8eb-c884-dfd8-2579f6632517@wanadoo.fr>
Date:   Thu, 9 Dec 2021 23:19:08 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Joe Perches <joe@...ches.com>, james.smart@...adcom.com,
        ram.vegesna@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, hare@...e.de, dwagner@...e.de
Cc:     linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: elx: efct: Avoid a useless memset



Le 09/12/2021 à 22:57, Joe Perches a écrit :
> On Thu, 2021-12-09 at 22:51 +0100, Christophe JAILLET wrote:
>> 'io->sgl' is kzalloced just a few lines above. There is no need to memset
>> it another time.
> 
> Better to use kcalloc as well and delete the memset

Sure, thanks for spotting it Joe.

Should a clean v2 be sent or the patch in your reply is enough?
As your proposal is better than mine, if a v2 is needed, can you do it?

CJ


> 
>> diff --git a/drivers/scsi/elx/efct/efct_io.c b/drivers/scsi/elx/efct/efct_io.c
> []
>> @@ -62,7 +62,6 @@ efct_io_pool_create(struct efct *efct, u32 num_sgl)
>>   			return NULL;
>>   		}
>>   
>> -		memset(io->sgl, 0, sizeof(*io->sgl) * num_sgl);
>>   		io->sgl_allocated = num_sgl;
>>   		io->sgl_count = 0;
>>   
> 
> ---
>   drivers/scsi/elx/efct/efct_io.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/elx/efct/efct_io.c b/drivers/scsi/elx/efct/efct_io.c
> index 71e21655916a9..109483f3e3dfd 100644
> --- a/drivers/scsi/elx/efct/efct_io.c
> +++ b/drivers/scsi/elx/efct/efct_io.c
> @@ -56,13 +56,12 @@ efct_io_pool_create(struct efct *efct, u32 num_sgl)
>   		}
>   
>   		/* Allocate SGL */
> -		io->sgl = kzalloc(sizeof(*io->sgl) * num_sgl, GFP_KERNEL);
> +		io->sgl = kcalloc(num_sgl, sizeof(*io->sgl), GFP_KERNEL);
>   		if (!io->sgl) {
>   			efct_io_pool_free(io_pool);
>   			return NULL;
>   		}
>   
> -		memset(io->sgl, 0, sizeof(*io->sgl) * num_sgl);
>   		io->sgl_allocated = num_sgl;
>   		io->sgl_count = 0;
>   
> 
>