linux-kernel - Re: [PATCH v2] i2c: tegra: use i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9eceaba-df4e-0e75-d6a7-87cfdf45fced@gmail.com>
Date:   Fri, 10 Dec 2021 01:27:55 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>, andy.shevchenko@...il.com,
        jonathanh@...dia.com, ldewangan@...dia.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, thierry.reding@...il.com
Subject: Re: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq

09.12.2021 19:28, Akhil R пишет:
> -	err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> -				       &i2c_dev->bus_clk_rate);
> -	if (err)
> -		i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> +	i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);

Was this patch tested at all? Apparently it wasn't compile-tested.

drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-Wunused-variable]
 1635 |         int err;

BTW, MM, DRI and media mailing lists have nothing to do with this patch