linux-kernel - Re: [PATCH v3 2/3] block: don't delete queue kobject before its children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbKOj3lBEdJLE8mr@sol.localdomain>
Date:   Thu, 9 Dec 2021 15:17:35 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-mmc@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v3 2/3] block: don't delete queue kobject before its
 children

On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:
> On 12/7/21 5:35 PM, Eric Biggers wrote:
> > +	/* Now that all child objects were deleted, the queue can be deleted. */
> 
> Shouldn't the present tense be used above (were -> are)? Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

"deleted" is an action here, not a state.  I think it's fine as-is, but maybe
you would prefer the following?

	/* Now that we've deleted all child objects, we can delete the queue. */

- Eric