linux-kernel - Re: [PATCH] drivers:watchdog:remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43c04d21-2d05-ced2-5f32-4310fca67dde@roeck-us.net>
Date:   Wed, 8 Dec 2021 19:58:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     cgel.zte@...il.com, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        chiminghao <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cm>
Subject: Re: [PATCH] drivers:watchdog:remove unneeded variable

On 12/8/21 5:53 PM, cgel.zte@...il.com wrote:
> From: chiminghao <chi.minghao@....com.cn>
> 
> return value form directly instead of
> taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cm>
> Signed-off-by: chiminghao <chi.minghao@....com.cn>

No, this is an old watchdog driver. Functional fixes for those only, please.

Guenter

> ---
>   drivers/watchdog/pcwd_pci.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
> index 54d86fcb1837..edbc0f28d399 100644
> --- a/drivers/watchdog/pcwd_pci.c
> +++ b/drivers/watchdog/pcwd_pci.c
> @@ -215,10 +215,7 @@ static inline void pcipcwd_check_temperature_support(void)
>   
>   static int pcipcwd_get_option_switches(void)
>   {
> -	int option_switches;
> -
> -	option_switches = inb_p(pcipcwd_private.io_addr + 3);
> -	return option_switches;
> +	return inb_p(pcipcwd_private.io_addr + 3);
>   }
>   
>   static void pcipcwd_show_card_info(void)
>