linux-kernel - Re: [PATCH 6/7] workqueue: Remove the cacheline_aligned for nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bac7b124-9087-1712-c88a-fac54f3d2cc0@linux.alibaba.com>
Date:   Fri, 10 Dec 2021 07:31:29 +0800
From:   Lai Jiangshan <laijs@...ux.alibaba.com>
To:     Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] workqueue: Remove the cacheline_aligned for
 nr_running



On 2021/12/10 06:07, Tejun Heo wrote:
> On Tue, Dec 07, 2021 at 03:35:42PM +0800, Lai Jiangshan wrote:
>> From: Lai Jiangshan <laijs@...ux.alibaba.com>
>>
>> nr_running is never modified remotely after the schedule callback in
>> wakeup path is removed.
>>
>> Rather nr_running is often accessed with other fields in the pool
>> together, so the cacheline_aligned for nr_running isn't needed.
> 
> Does it even need to be atomic anymore?
> 

It doesn't need to be atomic, it is only modified in its associated CPU
in process context.