linux-kernel - Re: [PATCH] x86/boot/string: Add missing function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202112091536.2DDF0DF@keescook>
Date:   Thu, 9 Dec 2021 15:37:43 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] x86/boot/string: Add missing function declarations

On Fri, Nov 19, 2021 at 09:53:25AM -0800, Kees Cook wrote:
> Silence "missing function declaration" warnings from string.h when
> building under W=1.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---

Hi, just a quick ping on this little fix.

Thanks!

-Kees

>  arch/x86/boot/string.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index a232da487cd2..e5d2c6b8c2f1 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -8,8 +8,10 @@
>  #undef memcmp
>  
>  void *memcpy(void *dst, const void *src, size_t len);
> +void *memmove(void *dst, const void *src, size_t len);
>  void *memset(void *dst, int c, size_t len);
>  int memcmp(const void *s1, const void *s2, size_t len);
> +int bcmp(const void *s1, const void *s2, size_t len);
>  
>  /* Access builtin version by default. */
>  #define memcpy(d,s,l) __builtin_memcpy(d,s,l)
> @@ -25,6 +27,7 @@ extern size_t strnlen(const char *s, size_t maxlen);
>  extern unsigned int atou(const char *s);
>  extern unsigned long long simple_strtoull(const char *cp, char **endp,
>  					  unsigned int base);
> +long simple_strtol(const char *cp, char **endp, unsigned int base);
>  
>  int kstrtoull(const char *s, unsigned int base, unsigned long long *res);
>  int boot_kstrtoul(const char *s, unsigned int base, unsigned long *res);
> -- 
> 2.30.2
> 

-- 
Kees Cook