linux-kernel - Re: [PATCH v3] gpio:amdpt:add new device ID and 24-pin support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbHmAyVka7w814g7@smile.fi.intel.com>
Date:   Thu, 9 Dec 2021 13:18:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yuchang Hsu <saraon640529@...il.com>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl,
        Richard_Hsu@...edia.com.tw, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yd_Tseng@...edia.com.tw,
        Cindy1_Hsu@...edia.com.tw, Andrew_Su@...edia.com.tw
Subject: Re: [PATCH v3] gpio:amdpt:add new device ID and 24-pin support

On Thu, Dec 09, 2021 at 10:26:05AM +0800, Yuchang Hsu wrote:
> From: Hsu Yuchang <Richard_Hsu@...edia.com.tw>

Thanks for v3, my comments below.

As I pointed out the subject should be

	gpio: amdpt: add new device ID and 24-pin support

(mind the white spaces).

> This patch add an ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.

As Submitting Patches documentation advises the description should be in
imperative form:

	Add an ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.

> And we retrieve pin number by device_get_match_data().
> 
> Signed-off-by: Yuchang Hsu <Richard_Hsu@...edia.com.tw>

> --- Add AMDIF031 support

After cutter '--- ' line means _after_, and not on the same line.
The changelog contents should explain the changes in the patch versions,
and not the changes which is done in the patch against the code base, for
the latter the commit message suffices.

Look at the plenty of the examples you may find in the mail archive:
https://lore.kernel.org/linux-gpio/.

-- 
With Best Regards,
Andy Shevchenko