linux-kernel - Re: [PATCH 0/4] KVM: VMX: Fix handling of invalid L2 guest state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3f9f46d-a424-a58c-e503-9069f46585f3@redhat.com>
Date:   Thu, 9 Dec 2021 12:26:09 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+f1d2136db9c80d4733e8@...kaller.appspotmail.com,
        Maxim Levitsky <mlevitsk@...hat.com>
Subject: Re: [PATCH 0/4] KVM: VMX: Fix handling of invalid L2 guest state

On 12/7/21 20:30, Sean Christopherson wrote:
> Fixes and a test for invalid L2 guest state.  TL;DR: KVM should never
> emulate L2 if L2's guest state is invalid.
> 
> Patch 01 fixes a regression found by syzbot. Patch 02 closes what I suspect
> was the hole the buggy patch was trying to close.  Patch 03 is a related
> docs update.  Patch 04 is a selftest for the regression and for a subset
> of patch 02's behavior.
> 
> Sean Christopherson (4):
>    KVM: VMX: Always clear vmx->fail on emulation_required
>    KVM: nVMX: Synthesize TRIPLE_FAULT for L2 if emulation is required
>    KVM: VMX: Fix stale docs for kvm-intel.emulate_invalid_guest_state
>    KVM: selftests: Add test to verify TRIPLE_FAULT on invalid L2 guest
>      state
> 
>   .../admin-guide/kernel-parameters.txt         |   8 +-
>   arch/x86/kvm/vmx/vmx.c                        |  36 ++++--
>   tools/testing/selftests/kvm/.gitignore        |   1 +
>   tools/testing/selftests/kvm/Makefile          |   1 +
>   .../x86_64/vmx_invalid_nested_guest_state.c   | 105 ++++++++++++++++++
>   5 files changed, 138 insertions(+), 13 deletions(-)
>   create mode 100644 tools/testing/selftests/kvm/x86_64/vmx_invalid_nested_guest_state.c
> 

Queued, thanks.

Paolo