linux-kernel - Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2 IMX6ULZ SystemMaster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Dec 2021 10:36:31 -0300
From:   Ariel D'Alessandro <ariel.dalessandro@...labora.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, aisheng.dong@....com,
        ioana.ciornei@....com, jagan@...rulasolutions.com,
        kernel@...gutronix.de, krzk@...nel.org, linux-imx@....com,
        matt@...verse.com.au, matteo.lisi@...icam.com,
        meenakshi.aggarwal@....com, michael@...rulasolutions.com,
        nathan@...nel.org, robh+dt@...nel.org, s.hauer@...gutronix.de,
        shawnguo@...nel.org, tharvey@...eworks.com, robh@...nel.org
Subject: Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2
 IMX6ULZ SystemMaster

Hi Fabio,

On 12/8/21 4:26 PM, Fabio Estevam wrote:
> On Wed, Dec 8, 2021 at 4:21 PM Ariel D'Alessandro
> <ariel.dalessandro@...labora.com> wrote:
>>
>> From: Michael Trimarchi <michael@...rulasolutions.com>
>>
>> Add DTS of BSH SMM-M2 SystemMaster.
>>
>> This version comes with:
>> - 128 MiB DDR3 RAM
>> - 256 MiB Nand
>> - wifi
>> - bluetooth
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
>> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
>> ---
>>  arch/arm/boot/dts/Makefile               |   3 +-
>>  arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 146 +++++++++++++++++++++++
> 
> There is a typo in the Subject: it says imx8ulz, but it should be
> imx6ulz instead.

Ah, you're right. Will fix in v4.

> 
>> +/ {
>> +       model = "BSH SMM M2";
>> +       compatible = "bsh,imx6ulz-bsh-smm-m2", "fsl,imx6ull";
> 
> Shouldn't "fsl,imx6ulz" also be added here like it is done in
> imx6ulz-14x14-evk.dts?

Yes, it should. Will fix in v4.

Thanks a lot,
Ariel