linux-kernel - Re: [PATCH net-next v7 5/6] stmmac: dwmac-mediatek: add support for mt8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6deeba8396a72d3d0bb3cb6630bc0c36f652de80.camel@mediatek.com>
Date:   Thu, 9 Dec 2021 09:54:53 +0800
From:   Biao Huang <biao.huang@...iatek.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <srv_heupstream@...iatek.com>, <macpaul.lin@...iatek.com>,
        <angelogioacchino.delregno@...labora.com>, <dkirjanov@...e.de>
Subject: Re: [PATCH net-next v7 5/6] stmmac: dwmac-mediatek: add support for
 mt8195

On Wed, 2021-12-08 at 17:51 -0800, Jakub Kicinski wrote:
> On Thu, 9 Dec 2021 09:48:25 +0800 Biao Huang wrote:
> > Sorry for some typo in previous reply, fix it here.
> > 
> > All these warning lines share a similar semantics:
> > delay_val |= FIELD_PREP(xxx, !!val);
> > 
> > and, should come from the expansion of FIELD_PREP in
> > include/linux/bitfiled.h:
> > 
> >   FIELD _PREP --> __BF_FILED_CHECK --> "~((_mask) >>
> > __bf_shf(_mask)) &
> > (_val) : 0,"
> > 
> > ===============================================================
> > __BF_FILED_CHECK {
> > ...
> >   BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ?           \
> >                    ~((_mask) >> __bf_shf(_mask)) & (_val) : 0, \
> >                    _pfx "value too large for the field"); \ ...
> > ===============================================================
> > 
> > Should I fix it by converting
> >   delay_val |= FIELD_PREP(ETH_DLY_TXC_ENABLE, !!mac_delay-
> > >tx_delay);
> > to
> >   en_val = !!mac_delay->tx_delay;
> >   delay_val |= FIELD_PREP(ETH_DLY_TXC_ENABLE, en_val);
> > 
> > or other suggestions for these warnings?
> 
> I see, thanks for explaining. The code is fine, we can simply ignore
> this warning IMHO.
OK, thanks for your comments~