[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d3cb39b15900ad62@bloch.sibelius.xs4all.nl>
Date: Thu, 9 Dec 2021 15:19:29 +0100 (CET)
From: Mark Kettenis <mark.kettenis@...all.nl>
To: Hector Martin <marcan@...can.st>
Cc: sven@...npeter.dev, robh+dt@...nel.org, marcan@...can.st,
alyssa@...enzweig.io, kettenis@...nbsd.org, maz@...nel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: apple: Add t6000/t6001 MacBook Pro
14/16" compatibles
> From: Hector Martin <marcan@...can.st>
> Date: Thu, 9 Dec 2021 14:09:58 +0900
>
> This adds the initial apple,t6000 platforms:
>
> - apple,j314s - MacBook Pro (14-inch, M1 Pro, 2021)
> - apple,j316s - MacBook Pro (16-inch, M1 Pro, 2021)
>
> And the initial apple,t6001 platforms:
>
> - apple,j314c - MacBook Pro (14-inch, M1 Max, 2021)
> - apple,j316c - MacBook Pro (16-inch, M1 Max, 2021)
>
> Signed-off-by: Hector Martin <marcan@...can.st>
> ---
> .../devicetree/bindings/arm/apple.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
Reviewed-by: Mark Kettenis <kettenis@...nbsd.org>
> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index b23c8dc5a27d..8d93e8a6cc18 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -19,6 +19,13 @@ description: |
> - MacBook Air (M1, 2020)
> - iMac (24-inch, M1, 2021)
>
> + And devices based on the "M1 Pro" and "M1 Max" SoCs:
> +
> + - MacBook Pro (14-inch, M1 Pro, 2021)
> + - MacBook Pro (14-inch, M1 Max, 2021)
> + - MacBook Pro (16-inch, M1 Pro, 2021)
> + - MacBook Pro (16-inch, M1 Max, 2021)
> +
> The compatible property should follow this format:
>
> compatible = "apple,<targettype>", "apple,<socid>", "apple,arm-platform";
> @@ -60,6 +67,20 @@ properties:
> - apple,j457 # iMac (24-inch, 2x USB-C, M1, 2021)
> - const: apple,t8103
> - const: apple,arm-platform
> + - description: Apple M1 Pro SoC based platforms
> + items:
> + - enum:
> + - apple,j314s # MacBook Pro (14-inch, M1 Pro, 2021)
> + - apple,j316s # MacBook Pro (16-inch, M1 Pro, 2021)
> + - const: apple,t6000
> + - const: apple,arm-platform
> + - description: Apple M1 Max SoC based platforms
> + items:
> + - enum:
> + - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021)
> + - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021)
> + - const: apple,t6001
> + - const: apple,arm-platform
>
> additionalProperties: true
>
> --
> 2.33.0
Powered by blists - more mailing lists