linux-kernel - Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface Duo 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2697db33-753c-ead8-019f-5e2ef1773693@gmail.com>
Date:   Thu, 9 Dec 2021 17:03:50 +0100
From:   Konrad Dybcio <konradybcio@...il.com>
To:     Katherine Perez <kaperez@...ux.microsoft.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface
 Duo 2

Hi!

On 09/12/2021 00:51, Katherine Perez wrote:
> This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350
> Chipset
>
> Signed-off-by: Katherine Perez <kaperez@...ux.microsoft.com>
> Reviewed-by: Vinod Koul <vkoul@...nel.org>
> ---
>
> Changes since v1:
> - Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
> - Add chassis-type
>
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   .../qcom/sm8350-microsoft-surface-duo2.dts    | 369 ++++++++++++++++++
>   2 files changed, 370 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
>
> --
> 2.31.1

[...]


> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> @@ -0,0 +1,369 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (C) 2021, Microsoft Corporation
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>

This is now included in sm8350.dtsi


[...]

> +&usb_1 {
> +	dr_mode = "peripheral";
> +};
> +

Looks like you forgot to enable usb_1, but other than these two nits:


Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>


Konrad