linux-kernel - Re: [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZtRqr0xnS849ZEsDGMtnDNKgOZu=7ww5H_fvxoTDQpag@mail.gmail.com>
Date:   Fri, 10 Dec 2021 21:12:34 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Yann Gautier <yann.gautier@...s.st.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        loic.pallardy@...s.st.com
Subject: Re: [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible

On Fri, Dec 10, 2021 at 10:19 AM Yann Gautier <yann.gautier@...s.st.com> wrote:

> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <yann.gautier@...s.st.com>

Why not
Acked-by: Linus Walleij <linus.walleij@...aro.org>

> +      - description: Entry for STMicroelectronics variant of PL18x.
> +          This dedicated compatible is used by bootloaders.
> +        items:
> +          - const: st,stm32-sdmmc2
> +          - const: arm,pl18x
> +          - const: arm,primecell

You *could* mark it deprecated if it's not supposed to be used.
But no strong opinion.

Yours,
Linus Walleij