linux-kernel - Re: [PATCH v2] i2c: tegra: use i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfWrwPmMzbX5uYPgiXo_h=wtG=qc-VMFujJ37hR1ntV1A@mail.gmail.com>
Date:   Fri, 10 Dec 2021 10:51:02 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     Dmitry Osipenko <digetx@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>
Subject: Re: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq

On Fri, Dec 10, 2021 at 8:43 AM Akhil R <akhilrajeev@...dia.com> wrote:
>
> > 09.12.2021 19:28, Akhil R пишет:
> > > -     err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> > > -                                    &i2c_dev->bus_clk_rate);
> > > -     if (err)
> > > -             i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> > > +     i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);
> >
> > Was this patch tested at all? Apparently, it wasn't compile-tested.
> Sorry, it got somehow missed as the build did not fail when prepared
> the image for testing. Thanks for pointing this out.
> Would fix and update.

It is because Dmitry runs `make W=1 ...`. Otherwise these types of
warnings are hidden.

> > drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
> > drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-
> > Wunused-variable]
> >  1635 |         int err;
> >
> > BTW, MM, DRI and media mailing lists have nothing to do with this patch
> Even I was wondering on this, but apparently those lists are shown if get_maintainer.pl
> is run. Would remove the mailing lists going further.

I would recommend using my script [1] which has good heuristics.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko