linux-kernel - RE: [PATCH v3 2/2] misc: Add iop driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Dec 2021 01:19:25 +0000
From:   Tony Huang 黃懷厚 <tony.huang@...plus.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Tony Huang <tonyhuang.sunplus@...il.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "derek.kiernan@...inx.com" <derek.kiernan@...inx.com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: RE: [PATCH v3 2/2] misc: Add iop driver for Sunplus SP7021

Dear Greg:

> On Thu, Dec 09, 2021 at 04:58:09PM +0800, Tony Huang wrote:
> > +	while (1) {
> > +		if (p_iop_reg->iop_data7 == 0xaaaa)
> > +			break;
> > +	}
> 
> You can not create a loop that could never exit.  Please fix.
> 

OK, I will modify it.

> Also, what prevents the compiler from optimizing this away into nothing?
> This code does not look correct at all.
> 
> > +
> > +	writel(0xdd, &p_iop_reg->iop_data1);//8051 bin file call Ultra low
> function.
> > +	mdelay(10);
> > +}
> > +
> > +static int  sp_iop_get_normal_code(struct device *dev, struct sp_iop
> > +*iop) {
> > +	const struct firmware *fw;
> > +	static const char file[] = "normal.bin";
> > +	unsigned int err, i;
> > +
> > +	dev_info(dev, "normal code\n");
> 
> Please always delete your debugging code before submitting a patch.
> 

OK, I will delete it.

> Also, please run checkpatch.pl on your changes before submitting them.
> 
> thanks,
> 
> greg k-h