linux-kernel - Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc535d3d-6dcd-e69c-24e7-df54ce63c381@loongson.cn>
Date:   Fri, 10 Dec 2021 17:54:33 +0800
From:   zhuyinbo <zhuyinbo@...ngson.cn>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Kosina <jikos@...nel.org>, benjamin.tissoires@...hat.com,
        gregkh@...uxfoundation.org, Thinh.Nguyen@...opsys.com,
        mathias.nyman@...ux.intel.com, stern@...land.harvard.edu,
        rajatja@...gle.com, chris.chiu@...onical.com,
        linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhuyinbo@...ngson.cn,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Rajat Jain <rajatja@...gle.com>,
        Chris Chiu <chris.chiu@...onical.com>,
        linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for
 usbhid device



在 2021/12/8 下午7:55, Greg Kroah-Hartman 写道:
> On Wed, Dec 08, 2021 at 05:39:50PM +0800, Yinbo Zhu wrote:
>> The remote wake-up function is a regular function on usb hid device
>> and I think keeping it enabled by default will make usb application
>> more convenient. This patch is to enable remote wakeup function for
>> usb hid device.
> 
> How many devices did you test this on?
> 
> As Oliver said, this will cause problems, there's a reason no operating
> system does this :(
> 
> sorry,
> 
> greg k-h
Hi greg,

About that oliver said that I had expained, and I add this change was 
according that usb device whether support remote wakeup and if it 
support wakeup then to enabled it so I think it should be okay for all 
hid device.

BRs,
Yinbo.
>