linux-kernel - Re: [PATCH] tools/perf: remove unneeded variable make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <500a4cce-1e71-fd8a-8fa3-39eb09964e97@linux.ibm.com>
Date:   Fri, 10 Dec 2021 18:14:46 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     cgel.zte@...il.com, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, namhyung@...nel.org, chi.minghao@....com.cn,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cm>
Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner



On 12/10/21 4:12 PM, Peter Zijlstra wrote:
> On Fri, Dec 10, 2021 at 02:41:55PM +0530, kajoljain wrote:
>>
>>
>> On 12/10/21 7:59 AM, cgel.zte@...il.com wrote:
>>> From: Minghao Chi <chi.minghao@....com.cn>
>>>
>>> return value form directly instead of
>>> taking this in another redundant variable.
>>
>> Can we reword the commit message stating what and
>> from where we are removing it. Its not too clear.
>> Other than that patch looks good to me.
>>
>> Reviewed-By: Kajol Jain<kjain@...ux.ibm.com>
> 
> Never reply or accept email from cgel.zte@...il.com, there's multiple
> people using it to send email, this cannot be right.
> 

Sure peter, Thanks for pointing it. Will take care next time.

Thanks,
Kajol Jain