linux-kernel - Re: [PATCH] xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI from runtime suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e2f77e9-952c-de4d-6efc-3f5c75a6285b@linux.intel.com>
Date:   Fri, 10 Dec 2021 16:22:17 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     mathias.nyman@...el.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:USB XHCI DRIVER" <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI
 from runtime suspending

On 9.12.2021 8.42, Kai-Heng Feng wrote:
> On Wed, Dec 1, 2021 at 5:00 PM Mathias Nyman
> <mathias.nyman@...ux.intel.com> wrote:
>>
>> On 1.12.2021 2.19, Kai-Heng Feng wrote:
>>> On Fri, Nov 19, 2021 at 5:27 PM Kai-Heng Feng
>>> <kai.heng.feng@...onical.com> wrote:
>>>>
>>>> When the xHCI is quirked with XHCI_RESET_ON_RESUME, runtime resume
>>>> routine also resets the controller.
>>>>
>>>> This is bad for USB drivers without reset_resume callback, because
>>>> there's no subsequent call of usb_dev_complete() ->
>>>> usb_resume_complete() to force rebinding the driver to the device. For
>>>> instance, btusb device stops working after xHCI controller is runtime
>>>> resumed, if the controlled is quirked with XHCI_RESET_ON_RESUME.
>>>>
>>>> So always take XHCI_RESET_ON_RESUME into account to solve the issue.
>>>>
>>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>>>
>>> A gentle ping...
>>
>> Thanks
>> Adding to queue
> 
> I haven't found this patch in your repo. Can you please push it so I
> can backport it to downstream kernel?

Patch got shuffled around a bit.
It's now in my for-usb-linus branch, and sent to Greg

Thanks
-Mathias