linux-kernel - Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbN54u4fEKx54Gvc@kroah.com>
Date:   Fri, 10 Dec 2021 17:01:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     David Brazdil <dbrazdil@...gle.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Hans de Goede <hdegoede@...hat.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, Andrew Scull <ascull@...gle.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to
 userspace

On Fri, Dec 10, 2021 at 03:48:05PM +0000, David Brazdil wrote:
> In your first email you also mentioned removing the check in dice_probe()
> that only allows a single instance. On a second thought, I think it's
> simpler to keep it there for now, even if the memory is dynamically
> allocated, which I agree makes the code cleaner.

I don't remember what check you are talking about at all, sorry.

Remember some of us review hundreds of patches each week :(

> The reason being that if we allowed multiple instances, we'd also need
> some static unique identifier that ties the cdev filename to the DT entry,
> same as /dev/disk/by-uuid/. Just adding an index number to the misc
> device nodename based on DT probe order sounds very fragile, and
> anything more sophisticated sounds like too much trouble for something
> we don't have a clear use case for right now.

Just add a number to the device node name like every other device in the
system has.  Nothing new or special here, right?

thanks,

greg k-h